<html>
<head><meta charset="utf-8"><title>publish-toolstate failing · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html">publish-toolstate failing</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="208089426"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208089426" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208089426">(Aug 26 2020 at 13:20)</a>:</h4>
<p>Strange error here: <a href="https://github.com/rust-lang/rust/pull/75687#issuecomment-680872483">https://github.com/rust-lang/rust/pull/75687#issuecomment-680872483</a></p>



<a name="208089465"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208089465" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Amanieu <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208089465">(Aug 26 2020 at 13:20)</a>:</h4>
<p>From the raw log:</p>
<div class="codehilite"><pre><span></span><code>2020-08-26T13:11:35.4854650Z Traceback (most recent call last):
2020-08-26T13:11:35.4854844Z Creating issue:
2020-08-26T13:11:35.4855059Z   File &quot;/home/runner/work/rust/rust/src/tools/publish_toolstate.py&quot;, line 349, in &lt;module&gt;
2020-08-26T13:11:35.4855191Z     main()
2020-08-26T13:11:35.4855317Z   File &quot;/home/runner/work/rust/rust/src/tools/publish_toolstate.py&quot;, line 319, in main
2020-08-26T13:11:35.4856693Z {&quot;body&quot;: &quot;Hello, this is your friendly neighborhood mergebot.\nAfter merging PR rust-lang/rust#75687, I observed that the tool miri has failing tests.\nA follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.\n\ncc @TimDiekmann, do you think you would have time to do the follow-up work?\nIf so, that would be great!\n\nAnd nominating for compiler team prioritization.\n\n&quot;, &quot;assignees&quot;: [&quot;oli-obk&quot;, &quot;eddyb&quot;, &quot;RalfJung&quot;], &quot;labels&quot;: [&quot;A-miri&quot;, &quot;C-bug&quot;], &quot;title&quot;: &quot;`miri` no longer builds after rust-lang/rust#75687&quot;}
2020-08-26T13:11:35.4862491Z Unexpected error when creating issue for status regression: &lt;type &#39;exceptions.NameError&#39;&gt;
2020-08-26T13:11:35.4865706Z     cur_datetime
2020-08-26T13:11:35.4865922Z   File &quot;/home/runner/work/rust/rust/src/tools/publish_toolstate.py&quot;, line 250, in update_latest
2020-08-26T13:11:35.4868312Z     relevant_pr_number, relevant_pr_user, LABELS.get(tool, &#39;&#39;),
2020-08-26T13:11:35.4869528Z   File &quot;/home/runner/work/rust/rust/src/tools/publish_toolstate.py&quot;, line 176, in issue
2020-08-26T13:11:35.4871883Z     &#39;Authorization&#39;: &#39;token &#39; + github_token,
2020-08-26T13:11:35.4872228Z NameError: global name &#39;github_token&#39; is not defined
</code></pre></div>



<a name="208092818"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208092818" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208092818">(Aug 26 2020 at 13:47)</a>:</h4>
<p>ah token issue. it tried to create an issue that miri is broken but failed at the token <span aria-label="grinning" class="emoji emoji-1f600" role="img" title="grinning">:grinning:</span></p>



<a name="208093086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208093086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208093086">(Aug 26 2020 at 13:49)</a>:</h4>
<p><code>$TOOLSTATE_REPO_ACCESS_TOKEN</code> is defined. but the problem is <code>$TOOLSTATE_VALIDATE_MAINTAINERS_REPO</code> is undefined</p>



<a name="208147623"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208147623" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208147623">(Aug 26 2020 at 20:57)</a>:</h4>
<p>Hello infra folks!  Posting because I got this in <a href="https://github.com/rust-lang/rust/pull/75912#issuecomment-681110514">https://github.com/rust-lang/rust/pull/75912#issuecomment-681110514</a> after it was successfully bors-merged:<br>
<a href="/user_uploads/4715/yPCGcoLWYzLkfgUBYPMGmIck/image.png">image.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/yPCGcoLWYzLkfgUBYPMGmIck/image.png" title="image.png"><img src="/user_uploads/4715/yPCGcoLWYzLkfgUBYPMGmIck/image.png"></a></div>



<a name="208149062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208149062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208149062">(Aug 26 2020 at 21:08)</a>:</h4>
<p>Oh, looking at the log this might be the problem:</p>
<div class="codehilite"><pre><span></span><code>NameError: global name &#39;github_token&#39; is not defined
</code></pre></div>



<a name="208149165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208149165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208149165">(Aug 26 2020 at 21:09)</a>:</h4>
<p>merged with the other report</p>



<a name="208149172"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208149172" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208149172">(Aug 26 2020 at 21:09)</a>:</h4>
<p>and gah this also happened today</p>



<a name="208149231"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208149231" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208149231">(Aug 26 2020 at 21:10)</a>:</h4>
<p>too tired, can someone look into it? otherwise it'll wait till morning</p>



<a name="208149302"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208149302" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208149302">(Aug 26 2020 at 21:11)</a>:</h4>
<p>seems non-urgent</p>



<a name="208149314"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208149314" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208149314">(Aug 26 2020 at 21:11)</a>:</h4>
<p>I'll take a quick peek</p>



<a name="208149963"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208149963" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208149963">(Aug 26 2020 at 21:15)</a>:</h4>
<p><span class="user-mention" data-user-id="125254">@kennytm</span> you seem to have diagnosed this but I'm not following your diagnosis</p>



<a name="208150062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150062">(Aug 26 2020 at 21:16)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/blob/ffd59bf9c62125813abae8ca52f0ac3a67459e8f/src/tools/publish_toolstate.py#L279-L281">https://github.com/rust-lang/rust/blob/ffd59bf9c62125813abae8ca52f0ac3a67459e8f/src/tools/publish_toolstate.py#L279-L281</a></p>



<a name="208150105"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150105" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150105">(Aug 26 2020 at 21:17)</a>:</h4>
<p><del>the <code>github_token = os.environ.get('TOOLSTATE_REPO_ACCESS_TOKEN')</code> line should be moved above <code>if repo:</code> i think</del></p>



<a name="208150118"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150118" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150118">(Aug 26 2020 at 21:17)</a>:</h4>
<p>hm but why did this just start failing...?</p>



<a name="208150149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150149">(Aug 26 2020 at 21:17)</a>:</h4>
<p>and inconsistently, too</p>



<a name="208150263"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150263" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150263">(Aug 26 2020 at 21:18)</a>:</h4>
<p>hm okay I have a theory</p>



<a name="208150265"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150265" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150265">(Aug 26 2020 at 21:18)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/commit/2e6f2e885506ee46ea32622e33fe74d99774cf57">https://github.com/rust-lang/rust/commit/2e6f2e885506ee46ea32622e33fe74d99774cf57</a></p>



<a name="208150280"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150280" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150280">(Aug 26 2020 at 21:18)</a>:</h4>
<p>that commit changed the scoping rules for github_token</p>



<a name="208150306"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150306" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150306">(Aug 26 2020 at 21:19)</a>:</h4>
<p>yes</p>



<a name="208150322"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150322" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150322">(Aug 26 2020 at 21:19)</a>:</h4>
<p>previously it was defined in global scope, so when we went to execute the issue function things worked</p>



<a name="208150367"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150367" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150367">(Aug 26 2020 at 21:19)</a>:</h4>
<p>this is why we have compilers...</p>



<a name="208150502"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150502" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150502">(Aug 26 2020 at 21:20)</a>:</h4>
<p>I think I can just prefix github_token = by "global "</p>



<a name="208150550"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208150550" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208150550">(Aug 26 2020 at 21:20)</a>:</h4>
<p>but now I'm worried all our variables are implicitly global in def main</p>



<a name="208151032"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208151032" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208151032">(Aug 26 2020 at 21:25)</a>:</h4>
<p><span class="user-mention" data-user-id="125254">@kennytm</span> up for reviewing <a href="https://github.com/rust-lang/rust/pull/75958">https://github.com/rust-lang/rust/pull/75958</a>?</p>



<a name="208155945"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208155945" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208155945">(Aug 26 2020 at 22:14)</a>:</h4>
<p>Apologies, I did not catch that it was global. <span aria-label="frown" class="emoji emoji-1f641" role="img" title="frown">:frown:</span></p>



<a name="208162661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208162661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208162661">(Aug 26 2020 at 23:33)</a>:</h4>
<p>no worries, I didn't either</p>



<a name="208162668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208162668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208162668">(Aug 26 2020 at 23:33)</a>:</h4>
<p>I always forget that's a thing in python</p>



<a name="208184523"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/publish-toolstate%20failing/near/208184523" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/publish-toolstate.20failing.html#208184523">(Aug 27 2020 at 07:15)</a>:</h4>
<p>(This caused some confusion as the bot posted some nonsensical things about Miri failures. In case something Miri-specific like this happens again, a ping would be appreciated so I do not have to debug things that have already been figured out^^.)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>